-
Notifications
You must be signed in to change notification settings - Fork 79
Vercel AI SDK upgrade v4 -> v5 #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Vercel AI SDK upgrade v4 -> v5 #238
Conversation
7a65925 to
15f40f4
Compare
Misbah-Engr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
|
@jasonhedman Is it intentional that you require your approval for the checks to run? |
Yes for first-time contributors |
Misbah-Engr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the pnpm version
jasonhedman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great first step.
I changed a lot of the type definitions and usage, mainly to fully leverage the type-safety benefits of v5 of the SDK.
I would like to avoid user-defined types as much as possible as they mask what is happening internally within the AI SDK.
Please see my comments regarding turning off parts of the setup script conditionally. If you can provide justification as to why that is desired behavior i am happy to leave it in. The goal with the setup script is to aid first-time developers, so I would prefer to leave in most of the opinionated code.
Also I see you mocked the generateImage functionality which we will need before this can get merged.
|
I will address all the issues. Thanks for all the review and comments. |
2cbc7af to
c4e4543
Compare
…arve-outs, dynamic etsy import, smoke test
…m/main (establish merge base for PR)