Change GW_IP to self.gw_ip #129
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hard-coded 192.168.91.1 for the Tesla Inverters internal endpoint doesn't always work if you're using NAT. Change this to be compatible with the rest of the file and to enable this use-case.
jasonacox
reviewed
Jan 5, 2025
| @@ -493,7 +493,7 @@ def get_firmware_version(self, force=False, details=False): | |||
| pb.message.recipient.din = self.din # DIN of Powerwall | |||
| pb.message.firmware.request = "" | |||
| pb.tail.value = 1 | |||
| url = f'https://{GW_IP}/tedapi/v1' | |||
| url = f'https://{self.gw_ip}/tedapi/v1' | |||
There was a problem hiding this comment.
Wow! Great fix. This should have been self.gw_ip.
|
Thank you @Nexarian ! This looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hard-coded 192.168.91.1 for the Tesla Inverters internal endpoint doesn't always work if you're using NAT. Change this to be compatible with the rest of the file and to enable this use-case.
Tested with a custom NAT configuration to verify that the firmware loads properly with a non-192.168.91.1 host.