Recursive loops may occur during resolution

[emetsger]

Models may introduce loops when resolving relationships:

@type(...)
class Node {
@relationship(...)
Node parent;
// etc.
}

If the JSON for this Node has a parent relationship pointing to itself, the stack blows.

Even if the author makes poor modeling decisions, probably some protections should be put in place to avoid blowing the stack.

[jasminb]

@emetsger will take a look at this

PS
Sorry for late reply, was on vacation for a week

[emetsger]

@jasminb no apologies necessary, everyone needs a break once in a while!

[jasminb]

Been thinking about the issue and did review your resolution proposal.

I am thinking inline of having ThreadLocal cache that would be available trough entire response parsing lifecycle. This means that parser would reuse already parsed objects, eg:

If A is parsed once (A is identified by id and a type), it would be pushed to cache.

When relationship is resolved and JSON object is retrieved, identifier would be created and in case it is found in cache, cached object would be returned and hence no further pointers would be followed.

Now, ThreadLocal is kinda of overkill here but somehow having 2 versions of each method so just we can push cache around makes it more appealing to me.

[jasminb]

#34

[emetsger]

Now, ThreadLocal is kinda of overkill here but somehow having 2 versions of each method so just we can push cache around makes it more appealing to me.

Thanks for considering my approach! Using a ThreadLocal is fine with me! Many thanks!

[jasminb]

Resolved.

[kishoresiri]

Row
{
@relational
Subtable subtable;
}

Subtable
{
@RelationShipLinks
List rowList;
}
Response
{
List rowList;
}

when i try to convert above response object to JSON then josn object is not containing any relationship / include....
how to resolve this issue?

[kishoresiri]

Row
{
@relational
Subtable subtable;
}

Subtable
{
@relationshiplinks
List rowList;
}
Response
{
List rowList;
}

when i try to convert above response object to JSON then josn object is not containing any relationship / include....
how to resolve relations ?