Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relaxed alignment constraints for memory and array accesses #748

Merged
merged 13 commits into from
Mar 28, 2024
Merged

Relaxed alignment constraints for memory and array accesses #748

merged 13 commits into from
Mar 28, 2024

Conversation

vbgl
Copy link
Member

@vbgl vbgl commented Mar 12, 2024

Please contribute suggestions for concrete syntax.

@vbgl vbgl force-pushed the relax-alignment branch 2 times, most recently from 3769910 to 8683de0 Compare March 13, 2024 05:44
bgregoir
bgregoir previously approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@bgregoir bgregoir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it is ok. Should we want more for merging it ?

@vbgl
Copy link
Member Author

vbgl commented Mar 13, 2024

Let me check a few more things.

@vbgl vbgl force-pushed the relax-alignment branch 2 times, most recently from 8bf88ed to 8ea90a6 Compare March 13, 2024 12:29
@vbgl
Copy link
Member Author

vbgl commented Mar 13, 2024 •
edited
Loading

There should be an annotation in slicing operations, at least for consistency.

@vbgl vbgl force-pushed the relax-alignment branch from 8ea90a6 to aedf820 Compare March 13, 2024 14:56
@vbgl vbgl marked this pull request as ready for review March 13, 2024 14:57
@vbgl vbgl changed the title Opt-in relaxed alignment constraints for memory and array accesses Relaxed alignment constraints for memory and array accesses Mar 13, 2024
@vbgl vbgl force-pushed the relax-alignment branch 3 times, most recently from 9054d88 to 0471e14 Compare March 20, 2024 12:39
@vbgl vbgl force-pushed the relax-alignment branch 3 times, most recently from d2bb01d to a00763d Compare March 25, 2024 14:26
@vbgl vbgl mentioned this pull request Mar 25, 2024
Merged
@vbgl vbgl force-pushed the relax-alignment branch from a00763d to 2217054 Compare March 26, 2024 14:04
eponier
eponier previously approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@eponier eponier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments that you can decide to ignore. I let you squash and/or merge depending on what you find the cleanest solution.

proofs/lang/memory_model.v Outdated Show resolved Hide resolved
proofs/lang/memory_model.v Show resolved Hide resolved
proofs/compiler/stack_alloc.v Outdated Show resolved Hide resolved
proofs/compiler/stack_alloc_proof.v Show resolved Hide resolved
compiler/src/printFexpr.ml Outdated Show resolved Hide resolved
compiler/src/printCommon.ml Show resolved Hide resolved
compiler/src/pretyping.ml Outdated Show resolved Hide resolved
compiler/src/syntax.ml Outdated Show resolved Hide resolved
compiler/src/toEC.ml Outdated Show resolved Hide resolved
compiler/src/toEC.ml Outdated Show resolved Hide resolved
@vbgl
Copy link
Member Author

vbgl commented Mar 28, 2024

Thanks Jean-Christophe for your careful review. I think I’ve addressed your concerns.

@eponier
Copy link
Contributor

eponier commented Mar 28, 2024

The opam job was killed in the CI, similarly to #560 (comment). Do you have an idea of what happens? Maybe too much RAM used by the job? We should fix that in the long run, not for this PR of course.

@vbgl vbgl merged commit a5293ba into main Mar 28, 2024
1 check passed
@vbgl vbgl deleted the relax-alignment branch March 28, 2024 16:03
vbgl added a commit that referenced this pull request Mar 29, 2024
@vbgl
Relaxed alignment constraints for memory and array accesses (#748)
c5a7502 
Co-authored-by: Benjamin Grēgoire <[email protected]>
(cherry picked from commit a5293ba)
@vbgl vbgl mentioned this pull request Apr 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eponier eponier eponier approved these changes

@bgregoir bgregoir bgregoir left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vbgl @eponier @bgregoir