Refine eventsApi #3594
Merged
Refine eventsApi #3594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based off code from jashkenas#3476
jridgewell
force-pushed
the
eventsApi-refinements
branch
from
dea7107 to
9ad11dd
Compare
| // maps `{event: callback}`), reducing them by manipulating `memo`. | ||
| // Passes a normalized single event name and callback, as well as the `context`, | ||
| // `ctx`, and `listening` arguments to `iteratee`. | ||
| var eventsApi = function(iteratee, memo, name, callback, context, ctx, listening) { |
There was a problem hiding this comment.
|
@jashkenas: This should probably go out with 1.2 as well. |
|
Thanks. |
This was referenced May 18, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off code from #3476
These are the last changes (hopefully!) from the eventsApi refactor.