preview-tui: error to foreground

[luukvbaal]

Bring NNN_FIFO error to foreground and printf instead of echo

[luukvbaal]

The changes from #966 require the listen_on config option or --listen-on flag for kitty previews.

This option relegates the kitty remote control to a socket instead of terminal escape sequences which don't get caught properly when sent from a background process for some reason.

If anyone has any insight as to why this might be the case and if it can be fixed, I would be interested to know. For now however, suggesting the use of the listen_on config seems fine to me.

[luukvbaal]

If anyone has any insight as to why this might be the case and if it can be fixed, I would be interested to know. For now however, suggesting the use of the listen_on config seems fine to me.

I would say it's caused by the race condition for /dev/tty kovidgoyal mentions in in kovidgoyal/kitty#2658 (comment).
Suggesting the use of listen_on seems the best way forward in my opinion.

[jarun]

Thank you!

[jarun]

@luukvbaal can you please add the kitty specific notes in the ToDo list in brief? We need to put it in the release notes for users who are on kitty.

[jarun]

I added it. Also, in my experience previews are pretty smooth now with tmux.

[luukvbaal]

@luukvbaal can you please add the kitty specific notes in the ToDo list in brief? We need to put it in the release notes for users who are on kitty.

Kitty users will also be greeted with an error about the listen_on config but having it in the changelog is good. Thanks for adding it.

I added it. Also, in my experience previews are pretty smooth now with tmux.

Yeah I myself use tmux previews as well and it really feels as if its part of nnn with the recent changes in my opinion!

[jarun]

I see an issue with preview-tui-ext... when I hover on a directory, the previewer shows all entries in that dir recursively. All defaults. If the dir has a subdir with too many entries, I don't get to see the other entries in the subdir.

[luukvbaal]

Yeah I don't see the point of it either but this is the tree output that has always been default in preview-tui as far as I can tell. Except the -i flag is left there by mistake from when I used tree for iconlookup preview. #972 restores the old default.

We can discuss a new default I guess, a non-recursive preview of the hovered directory makes the most sense to me(the current iconlookup view) but I think @leovilok suggested the paged tree view be kept default since it was a requested feature.