Rename file with a long name

[ixzh]

Is your feature request related to a problem? Please describe.
Can't see what's been modified due to truncation to screen width

Describe the solution you'd like

If the file name is longer than screen width, the inplace rename will only display the beginning of the file name. Most of the time I want to modify the file extension or prepend some number before it, but can't see the cursor due to truncation. See below example:

Describe alternatives you've considered

ctrl-a and ctrl-e to jump to start/end of the line, and show it on screen (scrolling?)

Thanks!

[jarun]

Duplicate of #279.

[jarun]

Reopening as this can probably be fixed if the name itself can be scrolled when the cursor is at the edges but I don't have time for that.

@N-R-K @luukvbaal @leovilok any of you wanna give it a try?

[jarun]

I think the change needs to go in xreadline():

3488                 mvaddnwstr(xlines - 1, x, buf, len + 1);                                                                                                                                                           
3489                 move(xlines - 1, x + wcswidth(buf, pos));

where we should account for the number of columns and show the string till the cursor position when it exceeds COLS.

[jarun]

@ixzh please confirm if the issue is fixed with the patch.

[ixzh]

@ixzh please confirm if the issue is fixed with the patch.

Yes, it works! Thank you !!!

[N-R-K]

Hmmm, the cursor is one char to the left of where it should be for me.
Think we're off by one.

-			mvaddnwstr(xlines - 1, x, buf + (pos - (xcols - x)), xcols - x);
+			mvaddnwstr(xlines - 1, x, buf + (pos - (xcols - x) + 1), xcols - x);

[jarun]

Sorry, I can't repro. Please do the required manipulation and raise the PR.

[jarun]

Sorry, saw the full mail now.

[jarun]

I will add the fix now. Thanks!