Cross-platform build #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: falkTX <[email protected]>
Signed-off-by: falkTX <[email protected]>
Signed-off-by: falkTX <[email protected]>
|
Heh, this is pretty much exactly as far as I got when I started porting to linux. |
jarikomppa
reviewed
May 17, 2022
Makefile
Outdated
| @@ -0,0 +1,91 @@ | |||
| #!/usr/bin/make -f | |||
| # Makefile for FluidPlug # | |||
There was a problem hiding this comment.
lol copy&paste silliness, you didn't see anything 🌈
jarikomppa
reviewed
May 17, 2022
Makefile.mk
Outdated
| @@ -0,0 +1,297 @@ | |||
| #!/usr/bin/make -f | |||
| # Makefile for DPF # | |||
jarikomppa
reviewed
May 17, 2022
src/eval.cpp
Outdated
| @@ -727,14 +727,14 @@ std::string func2call(int func) | |||
| return s; | |||
| } | |||
|
|
|||
| WELL512 random; | |||
| WELL512 wrandom; | |||
There was a problem hiding this comment.
this probably should be gRandom, my bad
There was a problem hiding this comment.
I can change that, no worries.
It is just that we get a conflict with random function, leading to a build failure
Signed-off-by: falkTX <[email protected]>
Signed-off-by: falkTX <[email protected]>
|
just pushed fixes for the little issues you commented on. |
|
Thanks! |
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now building and running on Linux 🎉
Sadly it crashes anytime a JIT operation is triggered, so it is not as useful.
The
memofsfor any call is just very suspiciously wrong.I couldn't find why, sorry.
Allowing code to build is a good first step though, so here you go :)
In theory this should allow to build on macOS too, but I did not test this.