Skip to content

keyv - fix: serialize entries in setMany #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nathan-knight wants to merge 2 commits into from
Closed

keyv - fix: serialize entries in setMany #1397

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d1a9b4
keyv - fix: serialize entries in setMany before passing them to the s…
nathan-knight Apr 29, 2025
e879618
fix linting issues
nathan-knight May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion packages/keyv/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,7 +619,27 @@ export class Keyv<GenericValue = any> extends EventManager {
try {
// If the store has a setMany method then use it
if (this._store.setMany !== undefined) {
results = await this._store.setMany(entries);
const serializedEntries = await Promise.all(entries.map(async ({key, value, ttl}) => {
if (ttl === undefined) {
ttl = this._ttl;
}

if (ttl === 0) {
ttl = undefined;
}

const expires = (typeof ttl === 'number') ? (Date.now() + ttl) : null;

if (typeof value === 'symbol') {
this.emit('error', 'symbol cannot be serialized');
throw new Error('symbol cannot be serialized');
}

const formattedValue = {value, expires};
const serializedValue = await this.serializeData(formattedValue);
return {key, value: serializedValue, ttl};
}));
results = await this._store.setMany(serializedEntries);
return results;
}

Expand Down
Loading