Fix build warnings.

jaredsinclair · Sep 14, 2015 · 97ee83a · 97ee83a
1 parent 717b253
commit 97ee83a
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 7 deletions.
diff --git a/Sample App/JTSImageVC/JTSImageVC.xcodeproj/project.pbxproj b/Sample App/JTSImageVC/JTSImageVC.xcodeproj/project.pbxproj
@@ -253,7 +253,7 @@
 			isa = PBXProject;
 			attributes = {
 				CLASSPREFIX = JTS;
-				LastUpgradeCheck = 0510;
+				LastUpgradeCheck = 0700;
 				ORGANIZATIONNAME = "Nice Boy, LLC";
 				TargetAttributes = {
 					7F9A791B18E754A7000CAA69 = {
@@ -387,6 +387,7 @@
 				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 				"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
 				COPY_PHASE_STRIP = NO;
+				ENABLE_TESTABILITY = YES;
 				GCC_C_LANGUAGE_STANDARD = gnu99;
 				GCC_DYNAMIC_NO_PIC = NO;
 				GCC_OPTIMIZATION_LEVEL = 0;
@@ -448,6 +449,7 @@
 				GCC_PREFIX_HEADER = "JTSImageVC/JTSImageVC-Prefix.pch";
 				INFOPLIST_FILE = "JTSImageVC/JTSImageVC-Info.plist";
 				IPHONEOS_DEPLOYMENT_TARGET = 7.0;
+				PRODUCT_BUNDLE_IDENTIFIER = "com.jaredsinclair.${PRODUCT_NAME:rfc1034identifier}";
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				WARNING_CFLAGS = "";
 				WRAPPER_EXTENSION = app;
@@ -463,6 +465,7 @@
 				GCC_PREFIX_HEADER = "JTSImageVC/JTSImageVC-Prefix.pch";
 				INFOPLIST_FILE = "JTSImageVC/JTSImageVC-Info.plist";
 				IPHONEOS_DEPLOYMENT_TARGET = 7.0;
+				PRODUCT_BUNDLE_IDENTIFIER = "com.jaredsinclair.${PRODUCT_NAME:rfc1034identifier}";
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				WARNING_CFLAGS = "";
 				WRAPPER_EXTENSION = app;
@@ -474,7 +477,6 @@
 			buildSettings = {
 				BUNDLE_LOADER = "$(BUILT_PRODUCTS_DIR)/JTSImageVC.app/JTSImageVC";
 				FRAMEWORK_SEARCH_PATHS = (
-					"$(SDKROOT)/Developer/Library/Frameworks",
 					"$(inherited)",
 					"$(DEVELOPER_FRAMEWORKS_DIR)",
 				);
@@ -485,6 +487,7 @@
 					"$(inherited)",
 				);
 				INFOPLIST_FILE = "JTSImageVCTests/JTSImageVCTests-Info.plist";
+				PRODUCT_BUNDLE_IDENTIFIER = "com.niceboy.${PRODUCT_NAME:rfc1034identifier}";
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				TEST_HOST = "$(BUNDLE_LOADER)";
 				WRAPPER_EXTENSION = xctest;
@@ -496,13 +499,13 @@
 			buildSettings = {
 				BUNDLE_LOADER = "$(BUILT_PRODUCTS_DIR)/JTSImageVC.app/JTSImageVC";
 				FRAMEWORK_SEARCH_PATHS = (
-					"$(SDKROOT)/Developer/Library/Frameworks",
 					"$(inherited)",
 					"$(DEVELOPER_FRAMEWORKS_DIR)",
 				);
 				GCC_PRECOMPILE_PREFIX_HEADER = YES;
 				GCC_PREFIX_HEADER = "JTSImageVC/JTSImageVC-Prefix.pch";
 				INFOPLIST_FILE = "JTSImageVCTests/JTSImageVCTests-Info.plist";
+				PRODUCT_BUNDLE_IDENTIFIER = "com.niceboy.${PRODUCT_NAME:rfc1034identifier}";
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				TEST_HOST = "$(BUNDLE_LOADER)";
 				WRAPPER_EXTENSION = xctest;

diff --git a/Sample App/JTSImageVC/JTSImageVC/JTSImageVC-Info.plist b/Sample App/JTSImageVC/JTSImageVC/JTSImageVC-Info.plist
@@ -9,7 +9,7 @@
 	<key>CFBundleExecutable</key>
 	<string>${EXECUTABLE_NAME}</string>
 	<key>CFBundleIdentifier</key>
-	<string>com.jaredsinclair.${PRODUCT_NAME:rfc1034identifier}</string>
+	<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundleName</key>

diff --git a/Sample App/JTSImageVC/JTSImageVC/JTSViewController.m b/Sample App/JTSImageVC/JTSImageVC/JTSViewController.m
@@ -28,7 +28,7 @@ - (void)viewDidLoad {
     self.bigImageButton.layer.cornerRadius = self.bigImageButton.bounds.size.width/2.0f;
 }
 
-- (NSUInteger)supportedInterfaceOrientations {
+- (UIInterfaceOrientationMask)supportedInterfaceOrientations {
     return UIInterfaceOrientationMaskPortrait;
 }
 

diff --git a/Sample App/JTSImageVC/JTSImageVCTests/JTSImageVCTests-Info.plist b/Sample App/JTSImageVC/JTSImageVCTests/JTSImageVCTests-Info.plist
@@ -7,7 +7,7 @@
 	<key>CFBundleExecutable</key>
 	<string>${EXECUTABLE_NAME}</string>
 	<key>CFBundleIdentifier</key>
-	<string>com.niceboy.${PRODUCT_NAME:rfc1034identifier}</string>
+	<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundlePackageType</key>

diff --git a/Source/JTSImageViewController.m b/Source/JTSImageViewController.m
@@ -209,7 +209,7 @@ - (void)dealloc {
 
 #pragma mark - UIViewController
 
-- (NSUInteger)supportedInterfaceOrientations {
+- (UIInterfaceOrientationMask)supportedInterfaceOrientations {
 
     /*
      iOS 8 changes the behavior of autorotation when presenting a