Work around metadata-only PDB emit failures - #385
Merged
Conversation
Suppress PDB-specific emit options when reading metadata-only compiler logs until the Roslyn fix is available. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 89ca8e5d-3064-43bd-b395-4556f6630e14
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
==========================================
+ Coverage 95.83% 95.85% +0.01%
==========================================
Files 54 54
Lines 6174 6175 +1
Branches 710 710
==========================================
+ Hits 5917 5919 +2
Misses 138 138
+ Partials 119 118 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metadata-only compilations can retain PDB-specific emit options that current Roslyn mishandles, causing
EmitToMemoryfailures or invalid CodeView metadata. Roslyn PR dotnet/roslyn#85028 fixes this upstream, but that fix is not yet available in a package complog can reference.This temporarily normalizes metadata-only
EmitOptionswhileCompilerLogReaderrehydrates a compilation:Adds regression coverage demonstrating the upstream Roslyn failure and links the related issue and fix.
Testing
dotnet test src\Basic.CompilerLog.UnitTests\Basic.CompilerLog.UnitTests.csproj --framework net10.0 --no-restore --blame-hang --blame-hang-timeout 60s