Use natural sort to select the best SDK #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #268 +/- ##
==========================================
+ Coverage 94.94% 96.13% +1.19%
==========================================
Files 49 49
Lines 5658 5775 +117
Branches 586 599 +13
==========================================
+ Hits 5372 5552 +180
+ Misses 189 139 -50
+ Partials 97 84 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jaredpar
approved these changes
Sep 16, 2025
333fred
added a commit
to 333fred/complog
that referenced
this pull request
Sep 19, 2025
* upstream/main: Handle version in errorlog argument (jaredpar#269) Use natural sort to select the best SDK (jaredpar#268) Suppress warning about missing package sources (jaredpar#270) Improve `rsp` command (jaredpar#266) Bump the all-dependencies group with 1 update (jaredpar#267) Add license and repository information to CompilerLog.Util package (jaredpar#264) Handle unix apphosts (jaredpar#265) Bump the all-dependencies group with 4 updates (jaredpar#263) Make `ReadGeneratedFilesFromPdb` public (jaredpar#261)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, complog selects 9.0 sdk over 10.0. That's also impacting my ability to run ExportUtil tests locally because they use 10 sdk for building but then run against 9 sdk, failing with "lang version 14 is not valid".