Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @rollup/plugin-commonjs version #975

Closed
wants to merge 1 commit into from

Conversation

bartsidee
Copy link

We are working on a project and found a bug in the commonjs rollup plugin that prevents us from compiling the project properly for the commonjs module format which is failing on a nested symbol-observable depedency.

This is related to the issue reported her:
rollup/plugins#304

And was fixed in plugin release 12.0.0
https://github.com/rollup/plugins/blob/master/packages/commonjs/CHANGELOG.md#v1200

This PR proposes to upgrade the @rollup/plugin-commonjs module from 11.1.0 to 12.0.0 to address this.

Note: the latest version of @rollup/plugin-commonjs is 17.1.0, but I'm not fully able to access the potential impact

@vercel

This comment has been minimized.

@bartsidee bartsidee changed the title Upgrade to @rollup/plugin-commonjs Upgrade @rollup/plugin-commonjs version Feb 17, 2021
@agilgur5
Copy link
Collaborator

agilgur5 commented Feb 18, 2021

Thanks for the contribution @bartsidee .

I know @rollup/plugin-commonjs has many bugs and their CHANGELOG is far from the most readable, so I understand that struggle. The bugs break a few other things, such as #759 which is similarly caused by rollup/plugins#304, among other issues.

Unfortunately this is a breaking change and would have to go into a breaking release as such. There is also already an existing PR ready for the next breaking release: #889 .

So I'll have to close this as a duplicate as such.

In the meantime, you're welcome to update your resolutions to bump to the version you need (at your own risk).

@agilgur5 agilgur5 closed this Feb 18, 2021
@agilgur5 agilgur5 added scope: dependencies Pull requests that update a dependency file solution: duplicate This issue or pull request already exists version: minor Increment the minor version when merged labels Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: dependencies Pull requests that update a dependency file solution: duplicate This issue or pull request already exists version: minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants