Upgrade @rollup/plugin-commonjs version #975
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are working on a project and found a bug in the commonjs rollup plugin that prevents us from compiling the project properly for the
commonjs
module format which is failing on a nestedsymbol-observable
depedency.This is related to the issue reported her:
rollup/plugins#304
And was fixed in plugin release 12.0.0
https://github.com/rollup/plugins/blob/master/packages/commonjs/CHANGELOG.md#v1200
This PR proposes to upgrade the
@rollup/plugin-commonjs
module from11.1.0
to12.0.0
to address this.Note: the latest version of @rollup/plugin-commonjs is 17.1.0, but I'm not fully able to access the potential impact