Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document some of the optimizations #97

Merged
merged 4 commits into from
May 10, 2019
Merged

Document some of the optimizations #97

merged 4 commits into from
May 10, 2019

Conversation

jaredpalmer
Copy link
Owner

First pass at documenting the built-in optimizations. Did not proof read. So feel free to nitpick typos

cc @sw-yx

Closes #8.

@jaredpalmer jaredpalmer requested a review from swyxio May 10, 2019 14:56
@jaredpalmer jaredpalmer self-assigned this May 10, 2019
@jaredpalmer jaredpalmer requested a review from TrySound May 10, 2019 14:56
TrySound
TrySound approved these changes May 10, 2019
View reviewed changes
Copy link
Collaborator

@TrySound TrySound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jaredpalmer jaredpalmer merged commit 71212dd into master May 10, 2019
@jaredpalmer jaredpalmer deleted the docs/optimizations branch May 10, 2019 16:26
@swyxio
Copy link
Collaborator

swyxio commented May 10, 2019

very good writeup! if we were to do the fb minified code thing, we may have to fork babel-plugin-dev-expression so that it doesnt quite strip away the arguments, but minifies and appends them to a file instead somehow (probably based on a hash). do i have that intuition right?

@agilgur5 agilgur5 mentioned this pull request Sep 1, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrySound TrySound TrySound approved these changes

@swyxio swyxio Awaiting requested review from swyxio

Assignees

@jaredpalmer jaredpalmer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document how to use lodash/lodash-es optimization
3 participants
@jaredpalmer @swyxio @TrySound