-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: ignore dependabot for peer dependencies #904
Conversation
- several of the dependencies in the tree are only there because they are peerDeps, and not because we directly depend on them - they should only be upgraded in tandem with the dep(s) they are peers of and pretty much never in isolation - Greenkeeper made several PRs for peers which previously caused an erroneous/buggy update of `@types/jest` to 25 many months before Jest was upgraded to 25 - and honestly those Greenkeeper PRs for peers had confused me a good deal too
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
peerDeps all look to line up to me, but I think tslib
should probably be included in here too because of #719 (comment).
But somewhat problematically, it doesn't seem to have a peerDep on typescript
, meaning one wouldn't get a peerDep mismatch error if an incorrect version were installed. And that means it could be easy to forget to check/upgrade tslib
in tandem with typescript
... Hmmm, need to think about that.
This might be unintentional, so should check upstream in tslib
and perhaps file a PR.
Seems like microsoft/tslib#22 exists that goes into this. microsoft/tslib#22 (comment) seemed against using peerDeps but without an example that was difficult to understand how the use-case actually plays out (does it mean in the dependency tree or a single package?) |
Since older versions of Added a comment in the thread upstream, but think this is good to go as is due to above. Can always add more to the list as well. |
Cleaned up ~74 Greenkeeper branches associated with Think nearly all the rest can be cleaned up now too (~44 left). I think they're mostly minor version upgrades (hence no PR) or devDeps or both. Has taken a while to get here, have cleaned up 100s of Greenkeeper branches 😕 |
Deleted another ~12 Greenkeeper branches. They were mostly patch bumps of devDeps actually, a few minors and a few prod. Remaining ones seem to be all Prettier/ |
- several of the dependencies in the tree are only there because they are peerDeps, and not because we directly depend on them - they should only be upgraded in tandem with the dep(s) they are peers of and pretty much never in isolation - Greenkeeper made several PRs for peers which previously caused an erroneous/buggy update of `@types/jest` to 25 many months before Jest was upgraded to 25 - and honestly those Greenkeeper PRs for peers had confused me a good deal too
- several of the dependencies in the tree are only there because they are peerDeps, and not because we directly depend on them - they should only be upgraded in tandem with the dep(s) they are peers of and pretty much never in isolation - Greenkeeper made several PRs for peers which previously caused an erroneous/buggy update of `@types/jest` to 25 many months before Jest was upgraded to 25 - and honestly those Greenkeeper PRs for peers had confused me a good deal too
Description
several of the dependencies in the tree are only there because they
are peerDeps, and not because we directly depend on them
peers of and pretty much never in isolation
Greenkeeper made several PRs for peers which previously caused an
erroneous/buggy update of
@types/jest
to 25 many months before Jestwas upgraded to 25
good deal too
Tags
eslint-config-react-app
peers in Update eslint-plugin-flowtype to the latest version 🚀 #640 (comment) / Update eslint-plugin-react-hooks to the latest version 🚀 #642 (comment) / Update @typescript-eslint/parser to the latest version 🚀 #728 (comment) / Update @typescript-eslint/eslint-plugin to the latest version 🚀 #729 (comment) / Use compatible eslint-config-react-app and eslint-plugin-react-hooks. #890 (comment)jest-watch-typeahead
to a version for Jest 26 before we even upgraded to Jest 25Let's close some of the confusing Greenkeeper peer update PRs now that this has been configured:
Review Notes
I straight copy+pasted the
eslint-config-react-app
peerDeps from itspackage.json
, so they're alphabetized the same way and shouldn't have any spelling mistakes.