Add --max-warnings flag to tsdx lint
#858
Conversation
Works in a similar way to the --max-warnings flag in ESLint. If `tsdx lint` finds more than `--max-warnings` number of warnings, it exits with a non-zero code. Otherwise, it exits with 0
This comment has been minimized.
This comment has been minimized.
Make it more consistent with the other examples
There was a problem hiding this comment.
Thanks for the PR @georgevarghese185 ! Great work and comprehensive testing! Have a few suggestions below to improve this, but is otherwise good.
Was going to add that you need to have the option and example, but I see you figured out that piece yourself.
One thing missing is that the API Reference section in the README needs to be updated with the new output of tsdx lint --help with this change
|
Hey, @agilgur5 ! Thanks for the suggestions (and for being super polite 😃) I think I've addressed everything. Take another look and let me know if I've missed something or if it can be improved further. |
|
@allcontributors please add @georgevarghese185 for code, docs, test |
|
I've put up a pull request to add @georgevarghese185! 🎉 |
Works the same as ESLint's --max-warnings flag If `tsdx lint` finds no errors but more than `--max-warnings` number of warnings, it exits with a non-zero code. Otherwise, it exits with 0 - Add lint warning tests for this - Use default value of Infinity for --max-warnings flag - Update README's API Reference with new flag
Fixes #853
Works in a similar way to the --max-warnings flag in ESLint.
If
tsdx lintfinds more than--max-warningsnumber of warnings, it exits with a non-zero code. Otherwise, it exits with 0.