(remove): redundant/confusing tsconfig target in templates #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
- tsconfig target is always overwritten to ESNext by TSDX, and then
the rest of the transpilation is done by @babel/preset-env
- having templates with target set gives the false impression that
target can be freely configured
- also remove from tests as it's unused there
agilgur5
force-pushed
the
remove-template-target
branch
from
9f9016e
to
ffdec2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tsconfig target is always overwritten to ESNext by TSDX, and then
the rest of the transpilation is done by @babel/preset-env
target can be freely configured
also remove from tests as it's unused there
See #415 for more about why the target is overwritten by TSDX