(fix/ci): GitHub Actions should run on PRs as well #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- previously would only run on branches from origin, so PRs from a fork would not trigger them
|
oh i see. yea the master branch protection is something jared didnt want. 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fork would not trigger them
Follow up to #372 once I took a look at the GH Actions docs. @sw-yx GH Actions were probably working for your use case because you were using branches on this repo and not from a fork during your PRs. The Actions are running in this PR from my fork now.
Now oddly enough, #366 did run the Actions (being an origin branch), and somehow they passed???. I have no idea why the lint test didn't fail 😳
Also as a follow-up to this -- you probably want to add branch protection rules for
masterso the checks are required before passing. This would also make it easier to detect when there's a CI logic bug.