Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove async; fix test #212

Merged
merged 1 commit into from
Sep 23, 2019
Merged

remove async; fix test #212

merged 1 commit into from
Sep 23, 2019

Conversation

elado
Copy link
Contributor

@elado elado commented Sep 23, 2019 •
edited
Loading

  1. remove aynsc from lint CLI command. having async there swallows errors, and isn't necessary because no await is used.
  2. tests were broken, fixed.

@jaredpalmer jaredpalmer merged commit afb0281 into jaredpalmer:master Sep 23, 2019
@jaredpalmer
Copy link
Owner

Will cut a release tonight. Out at drinks with Ken right now

@agilgur5
Copy link
Collaborator

@allcontributors please add @elado for code, test, bug

@allcontributors allcontributors bot mentioned this pull request Mar 16, 2020
Merged
@allcontributors
Copy link
Contributor

@agilgur5

I've put up a pull request to add @elado! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elado @jaredpalmer @agilgur5