Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.gitignore file ignores pre-v0.7.1 version of "*.es" cache path instead of "*.esm" #148

Closed
dance2die opened this issue Jun 19, 2019 · 0 comments
Closed

.gitignore file ignores pre-v0.7.1 version of "*.es" cache path instead of "*.esm" #148

dance2die opened this issue Jun 19, 2019 · 0 comments
Labels
kind: bug Something isn't working

Comments

@dance2die
Copy link
Contributor

dance2die commented Jun 19, 2019 •
edited
Loading

Current Behavior

The hot fix ab22779 shows that

-module: `dist/${safeName}.es.production.js`
+module: `dist/${safeName}.esm.js`,

but .gitignore has .rts2_cache_es instead of .rts2_cache_esm thus causing cache files to be added to the git repository as shown below.

demo

Expected behavior

New cache folder after the HOTFIX should not include the new cache folder.

Suggested solution(s)

The gitignore template file should replace .rts2_cache_es with .rts2_cache_esm

X2CXv5FT3K

Additional context

I could do a PR on this if the issue indeed require changing the gitignore template.
I did a PR #149

Your environment

Software Version(s)
TSDX v0.7.1
TypeScript 3.4.5
npm/Yarn yarn version 1.16.0
Operating System Windows 10 build 1903 & Ubuntu 19.04
dance2die added a commit to dance2die/tsdx that referenced this issue Jun 19, 2019
@dance2die
fixed issue mentioned in jaredpalmer#148 - Gitignore contains '.rts2_…
807bd50 
…cache_esm'
@dance2die dance2die mentioned this issue Jun 19, 2019
Merged
dance2die added a commit to dance2die/tsdx that referenced this issue Jun 19, 2019
@dance2die
fixed 'react' gitignore template jaredpalmer#148
d30be37
jaredpalmer pushed a commit that referenced this issue Jun 19, 2019
@dance2die @jaredpalmer
fixed issue mentioned in #148 - Gitignore contains '.rts2_cache_esm' (#…
98cf1db 
…149)

* fixed issue mentioned in #148 - Gitignore contains '.rts2_cache_esm'

* fixed 'react' gitignore template #148
@agilgur5 agilgur5 added the kind: bug Something isn't working label Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@agilgur5 @dance2die