Adds the same behavior in the resetForm as a formik v1. #2205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/jared/formik-docs/3rtdh8xuu |
|
@krailler thanks! taking a peek now |
|
Hi @jaredpalmer any news? :) |
jaredpalmer
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #2034
In formik v1, resetForm use the initialValues from props, you can see here https://github.com/jaredpalmer/formik/blob/version-1.5.8/src/Formik.tsx#L532
In this case, I cannot use directly prop.initialValues, because the resetForm is a memorize callback and in some cases will not work properly (even adding as deps).
If you have another idea to get back the v1 behavior, feel free to comment, please 🤗