Move UIKit.Xaml dependency property registration out of UIKit.Layer's…

… constructor. Fixes microsoft#1930.
jaredhms · Feb 10, 2017 · c2b6d56 · c2b6d56
1 parent a47428f
commit c2b6d56
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 2 deletions.
diff --git a/Frameworks/UIKit.Xaml/Label.xaml.cpp b/Frameworks/UIKit.Xaml/Label.xaml.cpp
@@ -94,7 +94,7 @@ Private::CoreAnimation::LayerProperty^ Label::GetBorderThicknessProperty() {
 
 Windows::Foundation::Size Label::ArrangeOverride(Windows::Foundation::Size finalSize) {
     // Make sure we render vertically-centered text if possible, else cap at the containing layer's height.
-    // TODO: Do we actually need this call to Measure? 
+    // TODO: Issue #1946: Do we actually need this call to Measure?
     TextBlock->Measure(finalSize);
     if (TextBlock->DesiredSize.Height >= finalSize.Height) {
         TextBlock->VerticalAlignment = Windows::UI::Xaml::VerticalAlignment::Top;

diff --git a/Frameworks/UIKit.Xaml/Layer.xaml.cpp b/Frameworks/UIKit.Xaml/Layer.xaml.cpp
@@ -130,6 +130,11 @@ void Layer::_RegisterDependencyProperties() {
 // ObjectiveC Interop
 ////////////////////////////////////////////////////////////////////////////////////
 
+// Initializes our library for use; registers dependency properties, etc.
+UIKIT_XAML_EXPORT void UIKitXamlInitialize() {
+    UIKit::Xaml::Private::CoreAnimation::Layer::_RegisterDependencyProperties();
+}
+
 // Set one or more layer properties for the specified target xaml element
 UIKIT_XAML_EXPORT void XamlSetFrameworkElementLayerProperties(
     const Microsoft::WRL::ComPtr<IInspectable>& targetElement,

diff --git a/Frameworks/UIKit.Xaml/Layer.xaml.h b/Frameworks/UIKit.Xaml/Layer.xaml.h
@@ -100,12 +100,15 @@ public ref class Layer sealed : public ILayer {
         Windows::UI::Xaml::DependencyProperty^ get();
     }
 
+internal:
+    // Static entry point to register our dependency properties
+    static void _RegisterDependencyProperties();
+
 private:
     // Layer elements; created on demand
     Windows::UI::Xaml::Controls::Image^ _content;
 
     // Dependency properties for adding layer-like functionality to any FrameworkElement
-    static void _RegisterDependencyProperties();
     static bool s_dependencyPropertiesRegistered;
     static Windows::UI::Xaml::DependencyProperty^ s_layerContentProperty;
     static Windows::UI::Xaml::DependencyProperty^ s_sublayerCanvasProperty;

diff --git a/Frameworks/UIKit.Xaml/ObjCXamlControls.h b/Frameworks/UIKit.Xaml/ObjCXamlControls.h
@@ -65,6 +65,9 @@ UIKIT_XAML_EXPORT IInspectable* XamlGetLabelTextBox(const Microsoft::WRL::ComPtr
 // Layer.xaml.cpp
 ////////////////////////////////////////////////////////////////////////////////////
 
+// Initializes our library for use; registers dependency properties, etc.
+UIKIT_XAML_EXPORT void UIKitXamlInitialize();
+
 // Set one or more layer properties for the specified target xaml element
 UIKIT_XAML_EXPORT void XamlSetFrameworkElementLayerProperties(const Microsoft::WRL::ComPtr<IInspectable>& targetElement,
                                                               const Microsoft::WRL::ComPtr<IInspectable>& sublayerCanvasProperty,

diff --git a/Frameworks/UIKit/StarboardXaml/XamlCompositor.cpp b/Frameworks/UIKit/StarboardXaml/XamlCompositor.cpp
@@ -31,6 +31,7 @@
 
 #include "DisplayProperties.h"
 #include "LayerProxy.h"
+#include "../UIKit.Xaml/ObjCXamlControls.h"
 
 using namespace Microsoft::WRL;
 using namespace UIKit::Xaml::Private::CoreAnimation;
@@ -69,6 +70,8 @@ void Initialize(Windows::UI::Xaml::Controls::Grid^ rootGrid, ActivationType acti
     s_rootGrid->InvalidateArrange();
 
     s_rootGrid->SizeChanged += ref new SizeChangedEventHandler(&OnGridSizeChanged);
+
+    UIKitXamlInitialize();
 }
 
 ComPtr<IInspectable> GetRootElement() {