-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zipfile .suffix/.suffixes raises TypeError when zipfile has no filename #96
Comments
Thanks for the report. Will investigate. |
I'm not able to replicate the issue in tests. The tests are passing and they already exercised the first two concerns (filenames without an extension). And in 906d379, I added a test confirming that stem also works as expected with a filename starting with a dot. |
I found one error in the test above. The parentheses are misplaced for the try:
print((zfp / ".gitignore").stem)
except TypeError:
logger.exception("stem failed") |
Oh! The reason the other tests are failing is not because |
@jaraco thanks for the fix! |
You bet. I'll be getting this and others rolled into CPython soon. |
I'd also expect |
Yes. Good point. I think that came up in another thread. I'll address the |
output:
The text was updated successfully, but these errors were encountered: