Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints #2

Closed
bswck opened this issue Feb 19, 2024 · 4 comments
Closed

Add type hints #2

bswck opened this issue Feb 19, 2024 · 4 comments

Comments

@bswck
Copy link
Contributor

bswck commented Feb 19, 2024

jaraco/skeleton#98
@bswck bswck mentioned this issue Feb 19, 2024
Merged
@bswck bswck moved this to To Do in Typing Initiative Feb 19, 2024
jaraco added a commit that referenced this issue Apr 4, 2024
@jaraco
Add a few type hints. Ref #2
56892e2
jaraco added a commit that referenced this issue Jul 26, 2024
@jaraco
Declare project as typed.
2ae9f20 
Ref #2
@jaraco
Copy link
Owner

jaraco commented Jul 26, 2024

This project now has quite a few type hints and declares itself as typed, but I welcome even more.

@jaraco
Copy link
Owner

jaraco commented Jul 26, 2024

Gemini has some ideas for improvement.

@jaraco jaraco closed this as completed in e051242 Jul 26, 2024
@bswck
Copy link
Contributor Author

bswck commented Jul 26, 2024 •
edited
Loading

@jaraco We ran into a classic LLM trap :/
The type hints e051242 introduced are based off on deprecated type aliases. Tracking in #11.

@jaraco
Copy link
Owner

jaraco commented Jul 26, 2024

Thanks! I knew it was a risk. Thanks for any contribution you can provide.

@jaraco jaraco mentioned this issue Aug 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaraco @bswck