-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.11 test regressions due to changed exception messages #24
Comments
Thanks for the report. I do intend to add Python 3.11 support. I'm delayed due to actions/setup-python#213. |
With 141245e, tests now run against Python 3.11 in CI. |
Ugh. Once again, I'm finding the lxml dependency means the pipelines are broken in Python 3.11 until lxml provides binary builds for that Python version. |
At least on non-Windows targets, I guess you could also just install the needed packages and let lxml be built from source. |
For Linux, you could copy-paste it from https://github.com/pkgcore/pkgcheck/blob/master/.github/workflows/test.yml#L52 |
Good tips. Yeah, I considered that, but I'm reluctant to tweak this project and half a dozen others only for a few months and only to get partial support (Windows would still need to be disabled). Good news is in #25, I found a mostly non-invasive solution that worked well enough to get us to the point that now the tests are running in CI and the two tests you identified are marked as xfail, so we can know when they're fixed. |
I notice that both errors are failing with the same mode. When I searched for the error message, I found this same issue was reported here in fedora. |
That bug implicates bpo-46730 / python/cpython#90886. |
In jaraco/jaraco.test@6ef8187, I've created a function that will provide the required expectation based on Python version. I'm unsure whether I want to employ that function or simply drop the check for the expected exception message. |
On further consideration, I think I do want to employ that function, to keep the status quo, but maybe remove it after. |
Yeah, I think it'd be sufficient to do substring match for the property name. |
(via
tox -e py311
, with Python 3.11.0b3)The text was updated successfully, but these errors were encountered: