std: Remove rand crate and module
#158
Conversation
Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe
The allocator feature was removed in ralloc commit cd8d627ecd5eb633833fe9fb8973219c2101ff61. Closes japaric#153.
|
This PR fixes building steed with a recent rust-src version. |
Xargo.toml
Outdated
|
|
||
| [dependencies.compiler_builtins] | ||
| features = ["mem"] | ||
| git = "https://github.com/rust-lang-nursery/compiler-builtins" |
There was a problem hiding this comment.
why should we switch to the git version? rust-src contains a snapshot of that git repo. Is there some version mismatch problem?
There was a problem hiding this comment.
I wasn't aware that compiler-builtins was distributed with rust-src. Should it be removed from the other Xargo.toml files too?
There was a problem hiding this comment.
stupid question - I guess it makes sense for the Xargo.test.toml file since it there are a lot of "supported" platforms
collections and rand crates have been removed/replaced.
|
Actually, none of the Xargo.toml should specify compiler-builtins as a git repo. |
|
That should work, I think. @homunkulus r+ |
|
📌 Commit e56b319 has been approved by |
std: Remove `rand` crate and module I'm guessing the entire rand folder can be deleted (still contains rand/reader.rs), but I left it for now, since it wasn't removed in rust/src/libstd yet. Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe
|
💔 Test failed - status-travis |
std: Remove `rand` crate and module I'm guessing the entire rand folder can be deleted (still contains rand/reader.rs), but I left it for now, since it wasn't removed in rust/src/libstd yet. Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe
|
💔 Test failed - status-travis |
|
Mmh |
The |
|
@homunkulus r+ |
|
📌 Commit 2e9830c has been approved by |
std: Remove `rand` crate and module I'm guessing the entire rand folder can be deleted (still contains rand/reader.rs), but I left it for now, since it wasn't removed in rust/src/libstd yet. Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe
|
💔 Test failed - status-travis |
|
Problems with the Xargo sysroot. Let's try again. @homunkulus r+ |
|
📌 Commit 5883feb has been approved by |
std: Remove `rand` crate and module I'm guessing the entire rand folder can be deleted (still contains rand/reader.rs), but I left it for now, since it wasn't removed in rust/src/libstd yet. Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe
|
💔 Test failed - status-travis |
std: Remove `rand` crate and module I'm guessing the entire rand folder can be deleted (still contains rand/reader.rs), but I left it for now, since it wasn't removed in rust/src/libstd yet. Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe
|
💔 Test failed - status-travis |
std: Remove `rand` crate and module I'm guessing the entire rand folder can be deleted (still contains rand/reader.rs), but I left it for now, since it wasn't removed in rust/src/libstd yet. Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe
|
💔 Test failed - status-travis |
std: Remove `rand` crate and module I'm guessing the entire rand folder can be deleted (still contains rand/reader.rs), but I left it for now, since it wasn't removed in rust/src/libstd yet. Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe
|
💔 Test failed - status-travis |
std: Remove `rand` crate and module I'm guessing the entire rand folder can be deleted (still contains rand/reader.rs), but I left it for now, since it wasn't removed in rust/src/libstd yet. Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe
|
💔 Test failed - status-travis |
std: Remove `rand` crate and module I'm guessing the entire rand folder can be deleted (still contains rand/reader.rs), but I left it for now, since it wasn't removed in rust/src/libstd yet. Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe
|
💔 Test failed - status-travis |
I'm guessing the entire rand folder can be deleted (still contains rand/reader.rs), but I left it for now, since it wasn't removed in rust/src/libstd yet.
Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe