Skip to content
This repository has been archived by the owner on Dec 9, 2018. It is now read-only.

fix unit tests #115

Open
2 of 14 tasks
japaric opened this issue Feb 25, 2017 · 9 comments
Open
2 of 14 tasks

fix unit tests #115

japaric opened this issue Feb 25, 2017 · 9 comments

Comments

@japaric
Copy link
Owner

japaric commented Feb 25, 2017

@japaric
Copy link
Owner Author

japaric commented Feb 25, 2017

updated
cc @tbu-

japaric pushed a commit that referenced this issue Feb 25, 2017
some unit test currently don't compile. See #115
@tbu-
Copy link
Collaborator

tbu- commented Feb 25, 2017

Thanks, being able to run the test suite is great!

Looks like quite a bit could be gained by implementing env. What's the state of #72?

@japaric
Copy link
Owner Author

japaric commented Feb 25, 2017

@tbu- It breaks the powerpc (iirc?) target but works everywhere else. Wasn't sure if it was ok to drop support for one target ...

@japaric
Copy link
Owner Author

japaric commented Feb 25, 2017

or to be more specific, the startup (before main) stuff of the powepc target is already flaky. #72 requires doing more startup stuff which finishes breaking the powerpc target :-)

@tbu-
Copy link
Collaborator

tbu- commented Apr 23, 2017

In what context is the execution of the unit tests? It seems that std::rt::start is not executed when trying to cross test.

@japaric
Copy link
Owner Author

japaric commented Apr 23, 2017

In what context is the execution of the unit tests?

rustc will insert a vanilla main function into the library crate turning it into a binary crate so the test runner should behave like a normal program and execute _start and then std::rt::start and then main.

@tbu-
Copy link
Collaborator

tbu- commented Apr 23, 2017

Mh. It didn't print when I inserted a println! into the std::rt::start function.

@japaric
Copy link
Owner Author

japaric commented Apr 23, 2017

@tbu- I have sent you an invite to become a collaborator of this repo 🎉. Could you check off the tests that have been fixed in the issue description?

@tbu-
Copy link
Collaborator

tbu- commented Apr 23, 2017

Thank you. Did that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants