Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@japaric I've added travis-ci support for this. Maybe you could enable travis for this repo and activate it to run periodically, since at least some parts of the puzzle (which I've left commented out) are broken.
In particular,
AddressSanitizer
builds in--release
mode fail to compile, but I couldn't find a report about this anywhere. Is this a regression?The
MemorySanitizer
failing to work withcargo test
is reported here: rust-lang/rust#39610 so that's not a regression.From the docs it looks like the
LeakSanitizer
should work, but I have not managed to make it work. The examples don't fail anymore. Is this a regression? It compiles in my project, but then fails at run-time with a weird error message: https://travis-ci.org/gnzlbg/slice_deque/jobs/336126105#L473TheThreadSanitizer
is the only sanitizer that seems to work fine.EDIT: I had only one passing test for the
ThreadSanitizer
so obviously the data-race false positive reported in rust-lang/rust#39608 did not surface. Now it surfaces just fine, I've added a test to check that settingRUST_TEST_THREADS=1
works around this issue.