-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error handling #48
Error handling #48
Conversation
Thanks @bagel897 , this looks really great! Having it work well A few suggestions (all very small "nit-picks"), I hope you don't mind.
Let me know if you would like to change them before merging (or if you disagree), or I'll just merge your PR as is do the small changes later (likely on Monday morning) cheers, and thanks!! |
I'll do the changes monday morning, is that alright? |
That's perfect, thanks again Ellen.
…On Sat, Aug 12, 2023, 08:24 Ellen Agarwal ***@***.***> wrote:
1. Sounds good!
2. errorcontext.go still has the HTML template. But I understand
combining the two files, it'd make it simpler. Alternatively, I can move
the HTML report part back into errorcontext.go
3. Ill do that as well
I'll do the changes monday morning, is that alright?
—
Reply to this email directly, view it on GitHub
<#48 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABY5KE7BY7LA3VKE2LEWAGDXU4OSZANCNFSM6AAAAAA3NKM4H4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Thanks for the feedback!
Lmk if you have any other suggestions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
The problem
When gonb runs into errors, it generates HTML error reports. These are great for a jupyter notebook, but don't render in nbmake
The solution
Add an option to print out raw error messages instead of html reports, set by a command line flag. This works inside nbmake.
![image](https://private-user-images.githubusercontent.com/57874654/260105571-60d7601d-e34f-4be4-8e49-78d15ffbd143.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ3Mjg5MzAsIm5iZiI6MTcyNDcyODYzMCwicGF0aCI6Ii81Nzg3NDY1NC8yNjAxMDU1NzEtNjBkNzYwMWQtZTM0Zi00YmU0LThlNDktNzhkMTVmZmJkMTQzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI3VDAzMTcxMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVlNzZkY2NkNzY0ZWU0ZTE2YTAwN2VkY2E3NWQ2YjRkZDJjYTI2YTUwYmVhYmZiNGZlZWI3Mzk1NGU0ZTE5NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.nf71rn0c07uuOGmkHGwATArMLavZ6Ycp3GPf0hWHGg0)
![image](https://private-user-images.githubusercontent.com/57874654/260105635-21e22c34-641d-4fc2-ada3-2434e3b860d1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ3Mjg5MzAsIm5iZiI6MTcyNDcyODYzMCwicGF0aCI6Ii81Nzg3NDY1NC8yNjAxMDU2MzUtMjFlMjJjMzQtNjQxZC00ZmMyLWFkYTMtMjQzNGUzYjg2MGQxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI3VDAzMTcxMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE4MWRmNjQwZDFhZTA1YzE5NGRiMzlhM2M0MzRiZGVmNGVkMzgxZDU3MzY1ZjIwNWM4MWIwMGRiNzk5MzczZDQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Yovi5Wc3TlwKxs2nCV2qiFTZijW742yfDakGr7xQT8M)