Correct gsap module references #662
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds compatibility for fiddles etc. linking to old urls on ghpages
…ly when using as ES6 module in browserify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been having troubles getting ScrollMagic to work correctly as an ES6 module.
I use browserify for my build and subsequently have had to use browserify-shim for some extra bits (which was .
To lessen the usage of browserify-shim, I renamed the gsap modules to use the current gsap module convention, e.g.
gsap/nameOfModule.I found that I still have to rely on browserify-shim to alias and inject dependencies. This seemed to work (I had to modify
gsapas well to get thejquery.gsapplugin to work too... them's the breaks trying to use old-style jQuery plugins with ES6 modules!).