Skip to content

fix incorrect typings for compile get/set methods #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix incorrect typings for compile get/set methods #54

wants to merge 1 commit into from

Conversation

haakemon
Copy link
Contributor

@haakemon haakemon commented Nov 9, 2021

The typings for get/set methods for compile are incorrect. The set method only accepts 1 param, and set method only accepts 2 params.

This PR fixes the typings for get/set method for compile function.

@janl janl closed this Nov 17, 2021
@haakemon
Copy link
Contributor Author

haakemon commented Nov 17, 2021

Hi @janl

Thank you for the feedback. However, I think the PR should be reopened, you are looking at the incorrect lines.

Yes, the get/set functions themselves and typings are correct. This PR does not change the typings for those functions, as they are already correct.

The typings for get/set methods on the compile function however are not correct - these accept 1 and 2 parameters respectively;
https://github.com/janl/node-jsonpointer/blob/main/jsonpointer.js#L89
https://github.com/janl/node-jsonpointer/blob/main/jsonpointer.js#L92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants