Enable DefaultComesLast Checkstyle check (jenkinsci#5963)

janfaracik · Nov 26, 2021 · d2fa876 · d2fa876
1 parent 62cdc38
commit d2fa876
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/core/src/main/java/hudson/util/LineEndingConversion.java b/core/src/main/java/hudson/util/LineEndingConversion.java
@@ -50,15 +50,15 @@ public static String convertEOL(String input, EOLType type) {
                 // Convert line endings to Windows CR/LF
                 input = input.replace("\n", "\r\n");
                 break;
-            default:
-            case LF:
-            case Unix:
-                // Conversion already completed
-                return input;
             case LFCR:
                 // Convert line endings to LF/CR
                 input = input.replace("\n", "\n\r");
                 break;
+            case LF:
+            case Unix:
+            default:
+                // Conversion already completed
+                return input;
         }
         return input;
     }

diff --git a/pom.xml b/pom.xml
@@ -446,6 +446,7 @@ THE SOFTWARE.
                   -->
                   <module name="AvoidNoArgumentSuperConstructorCall" />
                   <module name="CovariantEquals" />
+                  <module name="DefaultComesLast" />
                   <module name="EqualsHashCode" />
                   <module name="NoEnumTrailingComma" />
                   <module name="OneStatementPerLine" />