Skip to content

Commit

Permalink
Adjust description margin/line height, make help button slightly larg…
Browse files Browse the repository at this point in the history
…e/more visible, remove hardcoded description text
  • Loading branch information
janfaracik committed Nov 22, 2021
1 parent ae97a26 commit 4a8e448
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
4 changes: 2 additions & 2 deletions core/src/main/resources/jenkins/model/Jenkins/configure.jelly
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ THE SOFTWARE.
<j:set var="instance" value="${it}" />
<j:set var="descriptor" value="${instance.descriptor}" />

<f:entry title="${%Home directory}" description="By default, Jenkins stores all of its data in this directory on the file system" help="/help/system-config/homeDirectory.html">
<f:entry title="${%Home directory}" description="${%By default, Jenkins stores all of its data in this directory on the file system}" help="/help/system-config/homeDirectory.html">
<div class="jenkins-quote jenkins-quote--monospace">${it.rootDir}</div>
</f:entry>
<f:entry title="${%System Message}" description="This message will be displayed at the top of the Jenkins main page. This can be useful for posting notifications to your users">
<f:entry title="${%System Message}" description="${%This message will be displayed at the top of the Jenkins main page. This can be useful for posting notifications to your users}">
<j:set var="readOnlyMode" value="${!h.hasPermission(app.MANAGE)}" />
<f:textarea name="system_message" value="${it.systemMessage}" disabled="${readOnlyMode?'true':null}" readonly="${readOnlyMode?'true':null}"
codemirror-mode="${app.markupFormatter.codeMirrorMode}" codemirror-config="${app.markupFormatter.codeMirrorConfig}" previewEndpoint="/markupFormatter/previewDescription"/>
Expand Down
16 changes: 9 additions & 7 deletions war/src/main/less/modules/form.less
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,10 @@

.jenkins-form-description {
display: block;
margin-top: 0;
margin-bottom: 0.75rem;
// Tweaked margin so that it appears visually centred when placed next to `.jenkins-form-label`
margin: -0.2rem 0 0.8rem 0;
color: var(--text-color-secondary);
line-height: 1.66;
}

.jenkins-quote {
Expand Down Expand Up @@ -564,16 +565,16 @@

.jenkins-help-button {
position: relative;
width: 18px;
height: 18px;
min-width: 18px;
min-height: 18px;
width: 20px;
height: 20px;
min-width: 20px;
min-height: 20px;
margin-left: 1ch;
display: inline-flex;
justify-content: center;
align-items: center;
line-height: 20px;
color: var(--text-color)!important;
line-height: 18px;
border-radius: 100%;

&::before {
Expand All @@ -596,6 +597,7 @@
left: 0;
bottom: 0;
right: 0;
border: 1px solid rgba(125, 125, 125, 0.35);
box-shadow: var(--form-input-glow);
border-radius: inherit;
opacity: 0.1;
Expand Down
2 changes: 0 additions & 2 deletions war/src/main/webapp/help/system-config/homeDirectory.html
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
<div>
<p>By default, Jenkins stores all of its data in this directory on the file
system.</p>
<p>
There are a few ways to change the Jenkins home directory:
<ul>
Expand Down

0 comments on commit 4a8e448

Please sign in to comment.