Fix checkbox help alignment, add theme support for YUI modals

janfaracik · Nov 29, 2021 · 4a44304 · 4a44304
1 parent 5566a69
commit 4a44304
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/core/src/main/resources/lib/form/entry.jelly b/core/src/main/resources/lib/form/entry.jelly
@@ -96,7 +96,7 @@ THE SOFTWARE.
         </j:if>
       </j:when>
       <j:otherwise>
-        <div class="jenkins-checkbox-help-wrapper">
+        <div>
           <d:invokeBody />
           <f:helpLink url="${attrs.help}" featureName="${title}"/>
         </div>

diff --git a/war/src/main/less/base/yui-compatibility.less b/war/src/main/less/base/yui-compatibility.less
@@ -216,3 +216,8 @@ div.yahooTree td {
     display: inline-block;
   }
 }
+
+.yui-panel,
+.yui-panel .bd {
+  background-color: var(--background) !important;
+}
diff --git a/war/src/main/less/modules/form.less b/war/src/main/less/modules/form.less
@@ -372,12 +372,18 @@
   }
 }
 
+// Align help buttons correctly with checkboxes
+
 .jenkins-checkbox-help-wrapper {
   display: flex;
   align-items: center;
   justify-content: flex-start;
 }
 
+.jenkins-checkbox + a.jenkins-help-button {
+  vertical-align: top;
+}
+
 .jenkins-checkbox {
   position: relative;
   display: inline-flex;