Fix help button not working on pipeline page, improves background of …

…help container
janfaracik · Oct 22, 2021 · 0a4ecee · 0a4ecee
1 parent ab8517a
commit 0a4ecee
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 7 deletions.
diff --git a/core/src/main/resources/lib/form/helpArea.jelly b/core/src/main/resources/lib/form/helpArea.jelly
@@ -27,7 +27,7 @@ THE SOFTWARE.
   <st:documentation>
     Place holder to lazy-load help text via AJAX.
   </st:documentation>
-  <div class="help-area">
+  <div class="help-area tr">
       <div class="help">${%Loading...}</div>
   </div>
 </j:jelly>
diff --git a/war/src/main/js/widgets/config/tabbar.less b/war/src/main/js/widgets/config/tabbar.less
@@ -192,11 +192,6 @@
         }
       }
 
-      // Help & descriptions
-      .help {
-        background: var(--configure-job-help-area-bg-color);
-      }
-
       p,
       .help,
       .setting-description {

diff --git a/war/src/main/less/base/style.less b/war/src/main/less/base/style.less
@@ -632,12 +632,26 @@ label.attach-previous {
 /* ====================== help ===================================== */
 
 .help {
+  position: relative;
   display: none;  /* hidden until loaded */
-  background-color: var(--help-area-bg-color);
   padding: 1rem;
   margin: 1rem 0;
   word-break: break-word;
   border-radius: 6px;
+  z-index: 0;
+
+  &::before {
+    content: "";
+    position: absolute;
+    top: 0;
+    left: 0;
+    bottom: 0;
+    right: 0;
+    background: var(--text-color);
+    opacity: 0.05;
+    z-index: -1;
+    border-radius: inherit;
+  }
 
   p:first-of-type {
     margin-top: 0;
-Original file line number
+Diff line change
@@ Expand Up / @@ -192,11 +192,6 @@ @@
             }
           }
-          // Help & descriptions
-          .help {
-            background: var(--configure-job-help-area-bg-color);
-          }
           p,
           .help,
           .setting-description {
@@ Expand Down @@