Windows: Add CR to ignore list for multi-line check #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: When using
ppx_expect
with Windows-style newlines (CRLF
vsLF
), the multi-line expectation fails with:Defect: The current code considers the
CR
(/r
) a character, and fails the check.Fix: Ignore the
/r
as we do for other whitespace.We hit this in our Windows build of esy: esy/esy#499
Signed-off-by: Bryan Phelps [email protected]