Kobo sync detect fixed layout #2262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@OzzieIsaacs just in case you missed it, this PR should fix some issues we are having with comic/manga files. It's interesting to get it merged. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Kobo sync the layout of the Kepub has to be explicitly given, unlike when books are imported over USB which Kobo will check the epub format and set the type accordingly.
Currently the Kobo sync metadata format always returns
KEPUBeven when the epub has the layout set to'pre-paginated'for fixed layout epubs.This PR checks if the layout is specified in the epub metadata and if the layout is set to be fixed will change the format accordingly to
EPUB3FL.This allows for epubs to take up the full screen which is useful for comics/manga and should fix #1219 and #1514