New 'first stage' step for sound-redesign #2590
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR modifies soundbase and all sound implementations at once, because all CSound implementations depend on CSoundbase, so these can't be merged one by one in steps. This first step however still has backwards compatibility to the rest of the code. The second stage steps will be removing the backwards compatibility (which a.o. will improve error handling), so than we need to modify main.cpp, client.cpp and probably some other files too. but this can be done in multiple PR'steps. The third stage steps will be using the new soundproperties functionality which will affect several gui files, but also these changes can be merged in multiple steps. NOTES: Since this PR Needs jamulussoftware#2583 Global MsgBoxes and Commandline to be implemented first, this commit has to include these changes into global.h and main.cpp too. The avoid clang-format issues again this PR also includes a modified settings.cpp.
Member
|
Closed. Since this depends on my PR first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies soundbase and all sound implementations at once, because
all CSound implementations depend on CSoundbase, so these can't be merged one by one in steps.
This first step however still has backwards compatibility to the rest of the code.
The second stage steps will be removing the backwards compatibility (which a.o. will improve error handling),
so than we need to modify main.cpp, client.cpp and probably some other files too. but this can be done in multiple PR'steps.
The third stage steps will be using the new soundproperties functionality which will affect several gui files,
but also these changes can be merged in multiple steps.
NOTES:
Since this PR Needs #2583 Global MsgBoxes and Commandline to be implemented first,
this commit has to include these changes into global.h and main.cpp too.
The avoid clang-format issues again this PR also includes a modified settings.cpp.
Short description of changes
CHANGELOG:
Context: Fixes an issue?
Does this change need documentation? What needs to be documented and how?
Status of this Pull Request
What is missing until this pull request can be merged?
Checklist