Allows access to search_string in searchable table views #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def search(search_string) | ||
| @filtered = true | ||
| @search_string = search_string |
There was a problem hiding this comment.
Does this still provide the correct value? For some reason I thought this gets overwritten (or is not up-to-date) somewhere later on.
There was a problem hiding this comment.
This sets the instance var every time someone types a new character and that function is run. You're right that it gets manipulated later on, but since we can't access that anymore (not sure what happened to that capability) i just reimplemented it like the filtered? method.
There was a problem hiding this comment.
There were some significant changes that had to happen in order to support searching on iOS 8+ so either some of that functionality got lost on accident or couldn't be supported.
Co-Authored-By: markrickert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #811