Add ability to replace the nav stack while pushing a new screen onto the nav stack. #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewhavens
force-pushed
the
feature/replace-nav-stack
branch
from
0a28ef3
to
8562822
Compare
| @@ -75,6 +76,11 @@ def push_view_controller(vc, nav_controller=nil, animated=true) | |||
| nav_controller.pushViewController(vc, animated: animated) | |||
| end | |||
|
|
|||
| def replace_nav_stack(screens, args = {}) | |||
| args[:animated] ||= true | |||
There was a problem hiding this comment.
This will always set args[:animated] to true (even if you set it manually to false).
Instead, try this:
args[:animated] = true if args[:animated].nil?There was a problem hiding this comment.
Oops, you're right.
| @@ -218,7 +218,7 @@ | |||
| it "should open the provided view controller as root view if no other conditions are met" do | |||
| parent_screen = HomeScreen.new | |||
| new_screen = BasicScreen.new | |||
| parent_screen.mock!(:open_root_screen) { |vc| vc.should.be == new_screen } | |||
| parent_screen.mock!(:open_root_screen) { |vc, args| vc.should.be == new_screen } | |||
| screen = parent_screen.open_screen new_screen | |||
| screen.should == new_screen | |||
| end | |||
There was a problem hiding this comment.
Add a test for this maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to replace the current nav stack. This is an essential feature when dealing with navigation controllers.