Added add_child_screen and remove_child_screen methods. #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,41 +25,6 @@ def modal? | |||
| self.modal == true | |||
| end | |||
|
|
|||
| def resolve_title | |||
There was a problem hiding this comment.
Made these methods private, like they should have been. No other changes, just moved them to the private method section.
|
👍 Looks good to me. |
* master: Adds tests for prepare_for_reuse and ensures that it's called before on_reuse More concise checking to see if web image managers are defined. Make sure prepareForReuse calls super. Adds support for SDWebImage and takes preference over JMImageCache Adds :searchable to the whitelisted properties a cell can have. Version 2.3.1 Minor tweak Added on_cell_created and on_cell_reused Minor formatting tweaks Created PM::TableScreen#set_up_accessibility, #editable? and moved tableView:commitEditingStyle:forRowAtIndexPath to a new PM::TableScreen::Editable module Added a spec for editable? Wrote the spec to test if the TableScreen has tableView:commitEditingStyle:forRowAtIndexPath Handle additional status_bar scenarios # Conflicts: # lib/ProMotion/screen/screen_module.rb
|
Fixed
|
jamonholmgren
added a commit
that referenced
this pull request
May 12, 2015
Added add_child_screen and remove_child_screen methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #463. Soliciting feedback. Includes docs and tests.