Update google_benchmark (trusted)

--- Manual changes: --- 1) Updated version of google_benchmark to fix windows compile error. New range: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/e8baf26..b177433 2) Remove unused sleep.[cc|h] from BUILD.gn. (Removed here: google/benchmark#1549) 3) Fix deprecation warnings (treated as errors) in allocation_perf.cc. benchmark::DoNotOptimize has deprecated overloads due to google/benchmark#1493. Bug: 1425054 --- Original message generated by autoroll: --- Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/e8baf26..efc89f0 link to benchmark directly for tests that aren't link_main_test (#1576) (dominic) https://chromium.googlesource.com/external/github.com/google/benchmark/+/efc89f0 Convert uses of `const char*` to `std::string` (#1567) (dominic) https://chromium.googlesource.com/external/github.com/google/benchmark/+/46d3c84 add '@' to correctly reference build file for libpfm (#1575) (dominic) https://chromium.googlesource.com/external/github.com/google/benchmark/+/68aa190 Address warnings on NVIDIA nvc++ (#1573) (Henrique Bucher) https://chromium.googlesource.com/external/github.com/google/benchmark/+/9f7dc38 simplify setting C++ standard (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/1b507cb [FR] Provide public accessors to benchmark name and arguments #1551 (#1563) (Mike Apodaca) https://chromium.googlesource.com/external/github.com/google/benchmark/+/f32748c use std::string for skip messages (#1571) (dominic) https://chromium.googlesource.com/external/github.com/google/benchmark/+/060d762 [FR] state.SkipWithMessage #963 (#1564) (Mike Apodaca) https://chromium.googlesource.com/external/github.com/google/benchmark/+/adb0d3d ... Change-Id: I69218b84b88fb1da25e740d7fb623528d526b85b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4429376 Reviewed-by: Toon Verwaest <[email protected]> Commit-Queue: Matthias Liedtke <[email protected]> Cr-Commit-Position: refs/heads/main@{#87139}
jamlee-t · Apr 18, 2023 · 51fd29c · 51fd29c
1 parent d2f064b
commit 51fd29c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/DEPS b/DEPS
@@ -232,7 +232,7 @@ deps = {
     'dep_type': 'cipd',
   },
   'third_party/google_benchmark/src': {
-    'url': Var('chromium_url') + '/external/github.com/google/benchmark.git' + '@' + 'e8baf2622591569a27615b31372d1e9cc046af10',
+    'url': Var('chromium_url') + '/external/github.com/google/benchmark.git' + '@' + 'b177433f3ee2513b1075140c723d73ab8901790f',
   },
   'third_party/googletest/src':
     Var('chromium_url') + '/external/github.com/google/googletest.git' + '@' + 'af29db7ec28d6df1c7f0f745186884091e602e07',

diff --git a/test/benchmarks/cpp/cppgc/allocation_perf.cc b/test/benchmarks/cpp/cppgc/allocation_perf.cc
@@ -26,8 +26,9 @@ BENCHMARK_F(Allocate, Tiny)(benchmark::State& st) {
   subtle::NoGarbageCollectionScope no_gc(*Heap::From(&heap()));
   for (auto _ : st) {
     USE(_);
-    benchmark::DoNotOptimize(
-        cppgc::MakeGarbageCollected<TinyObject>(heap().GetAllocationHandle()));
+    TinyObject* result =
+        cppgc::MakeGarbageCollected<TinyObject>(heap().GetAllocationHandle());
+    benchmark::DoNotOptimize(result);
   }
   st.SetBytesProcessed(st.iterations() * sizeof(TinyObject));
 }
@@ -42,8 +43,9 @@ BENCHMARK_F(Allocate, Large)(benchmark::State& st) {
   subtle::NoGarbageCollectionScope no_gc(*Heap::From(&heap()));
   for (auto _ : st) {
     USE(_);
-    benchmark::DoNotOptimize(
-        cppgc::MakeGarbageCollected<LargeObject>(heap().GetAllocationHandle()));
+    LargeObject* result =
+        cppgc::MakeGarbageCollected<LargeObject>(heap().GetAllocationHandle());
+    benchmark::DoNotOptimize(result);
   }
   st.SetBytesProcessed(st.iterations() * sizeof(LargeObject));
 }

diff --git a/third_party/google_benchmark/BUILD.gn b/third_party/google_benchmark/BUILD.gn
@@ -59,8 +59,6 @@ if (v8_enable_google_benchmark) {
       "src/src/perf_counters.h",
       "src/src/re.h",
       "src/src/reporter.cc",
-      "src/src/sleep.cc",
-      "src/src/sleep.h",
       "src/src/statistics.cc",
       "src/src/statistics.h",
       "src/src/string_util.cc",