Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Chrome + AdBlock #53

Closed
markilfin opened this issue Mar 8, 2012 · 4 comments
Closed

Google Chrome + AdBlock #53

markilfin opened this issue Mar 8, 2012 · 4 comments
Labels

Comments

@markilfin
Copy link

Hello James,
I found that your great plugin doesn't work with Google Chrome when AdBlock extension is installed.

  • Windows 7 x64 SP1
  • Chrome 17.0.963.66 m
  • AdBlock 2.5.20
@jamietre
Copy link
Owner

jamietre commented Mar 8, 2012

Already fixed in the current dev version:

https://raw.github.com/jamietre/ImageMapster/master/dist/jquery.imagemapster.js

If you find this doesn't work for you for some reason reopen this issue, thanks.

This will be called version 1.3 in about 24 hours.

@jamietre jamietre closed this as completed Mar 8, 2012
@jamietre jamietre reopened this Mar 8, 2012
@jamietre
Copy link
Owner

jamietre commented Mar 8, 2012

On further looking it seems to cause it to break inconsistently, will look into it.

@jamietre
Copy link
Owner

jamietre commented Mar 8, 2012

Resolved in build just pushed 1.2.4.052

AdBlock appears to intercept image loads, not sure exactly why this was breaking things but something between the way jQuery checks image sizes and AdBlock inserting itself into the process caused ImageMapster to think the images were ready before they were. Added an extra layer of redundancy that should work no matter what, seems to be working good for me in chrome.

Also tested in IE7-9, FF 10.0.2, Chrome 17.0.963.56 m, Safari 5.1.2, Opera 11.61, no problems noted.

Let me know if this works for you too, thanks.

@jamietre jamietre closed this as completed Mar 8, 2012
@markilfin
Copy link
Author

James, thank you for such great attention.
Now it works perfectly.
Good luck ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants