Restricting values in the dropdown to valid values... attempt 2 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamieholst
pushed a commit
that referenced
this pull request
Dec 12, 2011
Restricting values in the dropdown to valid values + tabs are now spaces... attempt 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kept the change from tabs to spaces. I saw you fixed the other bug, so I didn't keep that one. The only difference between what I had before and the way it is now, is that the blur event calls the
handle_invalid_inputfunction. This meant that I had to pass the context into theinsert_text_fieldfunction. In order to do that, I rearranged some things ininit. I tested it a bunch and I feel pretty confident with it. Let me know what you think.References #24, #16.