Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put constant-elements plugin last #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

slorber
Copy link

@slorber slorber commented Apr 6, 2017

see babel/babel#5325 (comment)

There's a bug some of us have with this plugin, and it seems to disappear (or at least on some codebases) when this plugin is declared last in the list.

@gajus
Copy link

gajus commented May 29, 2017

Can replicate.

The error:

ERROR in ./app/components/MovieTile/index.js
Module parse failed: /Users/gajus/Documents/dev/applaudience/applaudience-com/node_modules/babel-loader/lib/index.js??ref--0!/Users/gajus/Documents/dev/applaudience/applaudience-com/dist/app/components/MovieTile/index.js Unexpected token (32:26)
You may need an appropriate loader to handle this file type.
| }, void 0, _jsx('b', {}, void 0, 'Change location'), _jsx('br', {}), 'to see other venues playing the movie.'));
|
| export default (function ((_temp = _ref, _ref6 = <MovieDetailsCard movie={movie} />, _temp)) {
|   var _temp, _ref6;
|
 @ ./app/index.js 1:0-47
 @ multi ./app

Example code thats causing this https://gist.github.com/gajus/1b851a3d753114ea856c85b742db9546

Repository owner deleted a comment from ImanMh Oct 3, 2017
Repository owner deleted a comment from Zip753 Oct 3, 2017
@LoicMahieu
Copy link

I found this error too

@ljbade
Copy link

ljbade commented Jan 15, 2018

We had this issue too.

@AndersDJohnson
Copy link

AndersDJohnson commented Feb 28, 2018

Same deal here. Any chance this can get merged in and a new version released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants