Fix v2 signature verification #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kherock
force-pushed
the
fix-v2-signatures
branch
from
004a768 to
4b8a1db
Compare
kherock
force-pushed
the
fix-v2-signatures
branch
from
4b8a1db to
7e38a25
Compare
|
@allan-simon v2 signature verification was actually quite broken and only functioned as expected for pre-signed URLs. I'm pretty confident #567 is fixed by this, but I haven't tested outside of the JavaScript AWS SDK. If you have time to test against this branch, please let me know if it's still not working for you. Once v3.6.0 is published I'll assume it's fixed otherwise. |
|
@kherock thanks for the ping :) looking to the code I think it will fix it yes ! don't wait for me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally I was under the impression that our test suite ran using v2 signatures for all requests, but they're actually defaulting to v4 signatures (and S3rver makes no attempt to verify those). Turning on v2 signatures makes a whopping 101/184 tests fail!
This PR fixes all v2 verification errors within the testing suite and resolves #513 (closes #526).