Koa rewrite #391
Merged
Koa rewrite #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kherock
force-pushed
the
next
branch
2 times, most recently
from
22f0091 to
efeb2cb
Compare
|
@leontastic review at your own peril, I know this is a lot. I'm hoping you'll like the approach I've taken. The only additional tests this should need are website redirects (redirecting /some/key to /some/key/ with a 302 when /some/key/index.html exists) and for XML-formatted 404 pages when making requests with the aws sdk. |
In particular, this focuses on * improved error handling and error formatting * making S3 features more modular * significantly more accurate static website behavior * simplify implementing new features in the future
This also corrects error handling to preserve CORS headers and exclude x-amz-error- headers from HTML responses.
They are undocumented, and the current behavior doesn't match S3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, this focuses on
This also fixes support for Node.js 10+