Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty directory cleanup when deleting a deeply nested key #387

Merged
merged 1 commit into from
Feb 7, 2019

Conversation

kherock
Copy link
Collaborator

@kherock kherock commented Feb 7, 2019

Resolves #375. The old implementation didn't check if the directory was empty after running the function on its children.

@kherock kherock merged commit ac94c19 into master Feb 7, 2019
} finally {
yield thunkToPromise(done => server.close(done));
}
});

it("Can put an object in a bucket that is empty after some key that does not include a directory has been deleted", function*() {
it("Can put an object in a bucket after all objects are deleted", function*() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that is a way better test description

@kherock kherock deleted the fix-375 branch February 19, 2019 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants