Require at least one Object in deleteObjects requests #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leontastic
reviewed
Feb 10, 2019
| error = err; | ||
| } | ||
| expect(error).to.exist; | ||
| expect(error.code).to.equal("MalformedXML"); |
There was a problem hiding this comment.
@kherock Do you think this could break users' code? I can imagine a naive deleteObject user might make empty requests sometimes. Should this be released in a patch, minor, or major release?
There was a problem hiding this comment.
As of a few patches ago, I'm pretty certain the server would just throw an unhandled error inside that callback function, so bringing this up to spec shouldn't be a big deal. I vote patch release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the way XML works, it's actually impossible to specify an empty array of Objects, so my concerns that an empty array would actually be allowed don't apply.