Fix range handling for oversized and out of range situations #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnardone
force-pushed
the
fix_range_handling
branch
from
1259dc2 to
3535434
Compare
|
Thanks for the simple fix, and nice use of |
|
Will do/did. Engine ver bumped and added an appropriate response header for the 416 response. Let me know if you need anything else. |
|
Anything else needed for this to get merged? |
kherock
added a commit
that referenced
this pull request
Feb 7, 2019
This ensures no file handles are left open after receiving an unsatisfiable range request by never opening the stream in the first place.
kherock
added a commit
that referenced
this pull request
Feb 7, 2019
This ensures no file handles are left open after receiving an unsatisfiable range request by never opening the stream in the first place.
kherock
added a commit
that referenced
this pull request
Feb 7, 2019
reimplement #373 to work on Windows
lukiano
reviewed
Mar 19, 2019
| object.range = { | ||
| start: options.start || 0, | ||
| end: options.end || object.size - 1 |
There was a problem hiding this comment.
I think this broke the range response header in 2.2.8, but looks like it's fixed on master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Range requests were doing a few things wrong:
This broke things that depend on range requests (notably s3-blob-store & feathers-blob) which we use extensively. Hoping for a quick merge & tag so we can keep pulling from the real upstream.
Thanks for a great project!